Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone - Protect admin and everyone roles #28451

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Standalone - Protect admin and everyone roles #28451

merged 1 commit into from
Dec 3, 2023

Conversation

wmortada
Copy link
Contributor

@wmortada wmortada commented Dec 3, 2023

Overview

We shouldn't allow users to edit or delete the admin and everyone roles as this could break the site.

Before

Users can edit and delete the admin and everyone roles and break the site.

After

Users are unable to edit and delete the admin and everyone roles.

Comments

For this PR to be fully effective, we need to limit the ability of super admins to do everything - see #28445.

@civibot civibot
Copy link

civibot bot commented Dec 3, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 3, 2023
@wmortada
Copy link
Contributor Author

wmortada commented Dec 3, 2023

@artfulrobot here's another one!

@wmortada wmortada force-pushed the standalone-protected-roles branch from 5deb910 to 7fbee0d Compare December 3, 2023 18:04
@colemanw colemanw mentioned this pull request Dec 3, 2023
Merged
@artfulrobot
Copy link
Contributor

I've tested this, it works! Thanks @wmortada @colemanw

@artfulrobot artfulrobot self-assigned this Dec 3, 2023
@colemanw
Copy link
Member

colemanw commented Dec 3, 2023

retest this please

@eileenmcnaughton eileenmcnaughton merged commit ec3684f into civicrm:master Dec 3, 2023
@wmortada wmortada deleted the standalone-protected-roles branch December 3, 2023 21:17
@wmortada wmortada mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@artfulrobot artfulrobot

Labels
comp:standalone master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wmortada @artfulrobot @colemanw @mlutfy @eileenmcnaughton